Closed antonis19 closed 3 years ago
Merging #1616 (9c5f4bf) into master (ed77718) will increase coverage by
0.10%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
+ Coverage 97.21% 97.31% +0.10%
==========================================
Files 68 68
Lines 2151 2157 +6
Branches 345 348 +3
==========================================
+ Hits 2091 2099 +8
+ Misses 31 30 -1
+ Partials 29 28 -1
Impacted Files | Coverage Δ | |
---|---|---|
snorkel/labeling/model/label_model.py | 96.30% <85.71%> (+0.76%) |
:arrow_up: |
@henryre I took care of the comments you made. Now there seems to be a build error even though all the tests pass. It seems to me that these are errors related to the build configuration, or am I wrong?
The build issues should be resolved on trunk. Re-running for this PR: https://github.com/snorkel-team/snorkel/pull/1616/checks?check_run_id=1764471482
@henryre seems that all the tests are passing except for codecov/patch. What would we need to do to fix this?
Description of proposed changes
Currently,
LabelModel
only accepts afloat
or anint
forprec_init
. These get converted into a 1D tensor of the same value. In this pull request,prec_init
can be passed asnp.ndarray
or as a Python list also. This way different labeling functions can get assigned different priors.Related issue(s)
Fixes #1484
Test plan
Checklist
Need help on these? Just ask!
tox -e complex
and/ortox -e spark
if appropriate.