Closed thatch closed 3 years ago
Hi @thatch, it looks like networkx 2.5 is now the stable version, and from a quick glance its dependencies look compatible with the current state of this project. If you'd like push your changes making the update to a PR, we can review it and just make the update outright.
@bhancock8 @thatch we need to upgrade networkx too. How does this look re: merging?
The PR resolving the issue has now been merged.
Issue description
Seeing as networkx 2.3 is more than a year old, I attempted to perform the trivial node/nodes change to make it work with networkx 2.5.
This uncovered a test failure in test_augmented_L_construction that I do not know enough about what it's doing to be able to fix.
Code example/repro steps
pip install -e .; pip install pytest
python -m unittest test.labeling.model.test_label_model
test_augmented_L_construction
-- here is theL_aug
On success, the first
j
is 4, and the next is 2.On failure, the first
j
is 6.Expected behavior
The test would pass.
System info
pip install -e .
Additional context
Add any other context about the problem here.