Fixing log issue for Label Model

snorkel-team / snorkel

A system for quickly generating training data with weak supervision

https://snorkel.org

Apache License 2.0

5.81k stars 857 forks source link

Fixing log issue for Label Model #1652

Closed anerirana closed 3 years ago

anerirana commented 3 years ago

Description of proposed changes

Changing log level to INFO when verbose is set to True in LabelModel.fit()

Related issue(s)

Fixes #1638

Test plan

No new test cases are required

Checklist

Need help on these? Just ask!

[x] I have read the CONTRIBUTING document.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] I have run tox -e complex and/or tox -e spark if appropriate.
[x] All new and existing tests passed.

anerirana commented 3 years ago

@bhancock8, I have made the discussed changes. But, the pipeline is failing at the build stage for python3.6, as the tox command does not complete in 15 minutes Travis wait time. Can you please suggest a way forward for this? Thank you.

bhancock8 commented 3 years ago

Thanks for the PR! We'll take a look into why the Python 3.6 unit tests are getting stuck, as it appears to be unrelated to this PR.

anerirana commented 3 years ago

Thanks @bhancock8, please merge the PR as well, because I don't have write access.

bhancock8 commented 3 years ago

Yep! I'll make sure this gets merged once the unit test build issue is resolved. Thanks @anerirana!