snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.81k stars 857 forks source link

Update numpy to >=1.20.0 #1653

Closed bhancock8 closed 2 years ago

bhancock8 commented 3 years ago

Description of proposed changes

Update numpy to resolve incompatibility with spacy, resulting in the following error message and failing CI tests on master:

ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 88 from C header, got 80 from PyObject

Test plan

Unit tests fail previously, confirm they pass after this update

Checklist

Need help on these? Just ask!

codecov[bot] commented 3 years ago

Codecov Report

Merging #1653 (f5a64c7) into master (39dc1c4) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files          68       68           
  Lines        2163     2165    +2     
  Branches      350      351    +1     
=======================================
+ Hits         2105     2107    +2     
  Misses         30       30           
  Partials       28       28           
Impacted Files Coverage Δ
snorkel/labeling/model/label_model.py 96.40% <100.00%> (+0.02%) :arrow_up:
github-actions[bot] commented 2 years ago

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.