snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.81k stars 857 forks source link

prevent pollution of top level 'test' namespace in site-packages #1659

Closed asottile closed 3 years ago

asottile commented 3 years ago

Description of proposed changes

the ./test directory was leaking into site-packages due to a misconfigured call to find_packages

Related issue(s)

Test plan

before:

$ git clean -fxfd >& /dev/null && python setup.py bdist_wheel >& /dev/null && unzip -l dist/*.whl | grep test
        0  2021-08-20 14:00   test/__init__.py
        0  2021-08-20 14:00   test/augmentation/__init__.py
        0  2021-08-20 14:00   test/augmentation/apply/__init__.py
    11665  2021-08-20 14:00   test/augmentation/apply/test_tf_applier.py
        0  2021-08-20 14:00   test/augmentation/policy/__init__.py
      693  2021-08-20 14:00   test/augmentation/policy/test_core.py
      907  2021-08-20 14:00   test/augmentation/policy/test_sampling.py
        0  2021-08-20 14:00   test/classification/__init__.py
...

after:

$ git clean -fxfd >& /dev/null && python setup.py bdist_wheel >& /dev/null && unzip -l dist/*.whl | grep test
$

Checklist

Need help on these? Just ask!

bhancock8 commented 3 years ago

Thanks for the PR!