clean up flake8 ignores - Githubissues

snorkel-team / snorkel

A system for quickly generating training data with weak supervision

https://snorkel.org

Apache License 2.0

5.81k stars 857 forks source link

clean up flake8 ignores #1660

Closed asottile closed 3 years ago

asottile commented 3 years ago

W605 should not be ignored, it will become a syntax error in the future
- I fixed the offenders automatically with pyupgrade
extend-ignore is better than ignore as it preserves the default ignore list

Description of proposed changes

Related issue(s)

Test plan

python -Wonce -c 'import snorkel.labeling.model.label_model'
python -Wonce -c 'import test.labeling.apply.lf_applier_spark_test_script'

Checklist

Need help on these? Just ask!

[x] I have read the CONTRIBUTING document.
[ ] I have updated the documentation accordingly. N/A
[x] I have added tests to cover my changes.
[ ] I have run tox -e complex and/or tox -e spark if appropriate. N/A
[x] All new and existing tests passed.

bhancock8 commented 3 years ago

Thank you for these updates, @asottile! All looks good to me. (The failing CI test is due to a separate known issue that we're investigating).