snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.81k stars 857 forks source link

Provide high_precision argument for predict_proba method #1672

Closed zehua99 closed 1 year ago

zehua99 commented 3 years ago

Description of proposed changes

This PR adds a new high_precision argument to the predict_proba method in LabelModel.

Related issue(s)

Fixes #1640

Test plan

Repeat the steps as described in #1640. When setting high_precision=False, the output is True (there are NaN values). When setting high_precision to True, the output is False.

Checklist

Need help on these? Just ask!

github-actions[bot] commented 2 years ago

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

rsmith49 commented 2 years ago

Hi @simonzli ! Sorry for the late reply. We recently went through some CI upgrades for the checks to become more streamlined. However, because of this, existing PRs such as this one have the old CI checks still attached.

Would you mind rebasing to the new master branch and pushing this PR from there? You can accomplish that by

git pull
git rebase master
git push --force

Thanks!

github-actions[bot] commented 2 years ago

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 years ago

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

rsmith49 commented 2 years ago

Hey @simonzli, checking in again. If you could run

git pull
git rebase main
git push --force

to get the CI working on this branch, I can go ahead and approve and merge it once it passes tests!

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.