Closed zehua99 closed 1 year ago
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Hi @simonzli ! Sorry for the late reply. We recently went through some CI upgrades for the checks to become more streamlined. However, because of this, existing PRs such as this one have the old CI checks still attached.
Would you mind rebasing to the new master branch and pushing this PR from there? You can accomplish that by
git pull
git rebase master
git push --force
Thanks!
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Hey @simonzli, checking in again. If you could run
git pull
git rebase main
git push --force
to get the CI working on this branch, I can go ahead and approve and merge it once it passes tests!
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Description of proposed changes
This PR adds a new
high_precision
argument to thepredict_proba
method inLabelModel
.Related issue(s)
Fixes #1640
Test plan
Repeat the steps as described in #1640. When setting
high_precision=False
, the output isTrue
(there are NaN values). When settinghigh_precision
toTrue
, the output isFalse
.Checklist
Need help on these? Just ask!
tox -e complex
and/ortox -e spark
if appropriate.