snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.82k stars 857 forks source link

Bumping numpy version for Mac M1 compat #1690

Closed rsmith49 closed 2 years ago

rsmith49 commented 2 years ago

Description of proposed changes

According to https://github.com/snorkel-team/snorkel/issues/1689, numpy versions lower than 1.21 are not supported by the new Mac M1 chips. Bumping the upper bound of numpy to accommodate this.

Related issue(s)

Fixes https://github.com/snorkel-team/snorkel/issues/1689

Test plan

Checklist

Need help on these? Just ask!

bhancock8 commented 2 years ago

Let's rebase now that #1696 is merged, then note on #1695 that this is now resolved.

zexuan-zhou commented 2 years ago

@rsmith49 I think merging this PR will help py37 and py38 CI builds

rsmith49 commented 2 years ago

@zexuan-zhou thanks for all the dev effort here! Looks like we addressed the mypy issues - ready for a review @bhancock8

zexuan-zhou commented 2 years ago

@bhancock8 @rsmith49 Will there be a version release for this or what version should I use to install the latest version. Thank you