zexuan-zhou
commented
2 years ago @rsmith49 @bhancock8 Please take a look. I need some help on the tests for py36, py37, and spark, and CICD. Thank you
Closed zexuan-zhou closed 2 years ago
zexuan-zhou
commented
2 years ago @rsmith49 @bhancock8 Please take a look. I need some help on the tests for py36, py37, and spark, and CICD. Thank you
rsmith49
commented
2 years ago @zexuan-zhou thanks for getting going here! Can you re-create this PR to merge into snorkel-team:update-numpy-version instead of snorkel-team:master? That way we can run the checks in CI after merging in these changes before merging into master
zexuan-zhou
commented
2 years ago @zexuan-zhou thanks for getting going here! Can you re-create this PR to merge into
snorkel-team:update-numpy-versioninstead ofsnorkel-team:master? That way we can run the checks in CI after merging in these changes before merging into master
@rsmith49 Done. Changed the base to snorkel-team:update-numpy-version
Description of proposed changes
Loosen versions for
numpy,blisto support M1 MacRelated issue(s)
https://github.com/snorkel-team/snorkel/issues/1695
Fixes # (issue) https://github.com/snorkel-team/snorkel/issues/1695
Test plan
Need help on this
Checklist
Need help on these? Just ask! Need help to test py36 and py37 as they are hard to install on M1 Mac. Need help on
tox -e sparkNeed help on CICD Need help on what document to update Need help on whether there should be new test casestox -e complexand/ortox -e sparkif appropriate. [X]tox -e complexruns and passes all test [ ]tox -e sparkis currently failing withException: Java gateway process exited before sending its port numbertox -e py38passes [X]tox -e complexpasses [X]tox -e doctestpasses [X]tox -e checkpasses [X]tox -e typepasses (all code changes are regarding this) [ ]tox -e py36 # Run unit tests pytest in Python 3.6[ ]tox -e py37 # Run unit tests pytest in Python 3.7[ ]tox -e spark # Run Spark-based tests (marked with @pytest.mark.spark)** [ ]tox -e doc # Build documentation with Sphinx