search

snosov1 / toc-org

toc-org is an Emacs utility to have an up-to-date table of contents in the org files without exporting (useful primarily for readme files on GitHub)
GNU General Public License v3.0
287 stars 29 forks source link

WIP Fix stripping of word "Comment" in headlines #69

Closed htsr closed 3 years ago

htsr commented 3 years ago

The COMMENT regexp search is case-insensitive so it incorrectly ignore heading starting with the french word "Comment" (how). This search is now case-sensitive.

snosov1 commented 3 years ago

Thanks for the catch!

2 things, though:

  1. There's no need for the "backup" variable, just use 
    (let ((case-fold-search nil))
;; BODY
)
  2. Please, add the respective test to catch this case.
htsr commented 3 years ago

Done! I've added 2 tests, both fail when my changes are reverted.

snosov1 commented 3 years ago

Looks good, let's mUrge!