do your tests still pass?

[mesqueeb]

I merged your master into my forks master and 2 tests failed. : S

do your tests still pass on v3?

[snovakovic]

@mesqueeb hmmm that is interesting!

Yes it's still passing for me. I have restraint on build so that tests need to pass in order to build and deploy project so would not be able to publish it otherwise.

@mesqueeb which 2 tests are failing on your end? what environment do you use? (node and OS)

[snovakovic]

@mesqueeb closing this issue as I can't replicate it.. if you can let me know on which environment it failed for you I can take another look into it.

[mesqueeb]

I think it was a fluke from my fork getting out of sync. : D I should've closed this myself way sooner !! Sorry.

[pkit]

git clone https://github.com/snovakovic/fast-sort
cd fast-sort
yarn

Still fails tests.

$ node --version
v14.17.3

  2) sort
       Should create sort instance that sorts nil value to the top in desc order:

      AssertionError: expected [ 'aa', 'aa', 'bb', null, undefined ] to deeply equal [ 'aa', 'aa', 'bb', undefined, null ]
      + expected - actual

       [
         "aa"
         "aa"
         "bb"
      +  [undefined]
         [null]
      -  [undefined]
       ]

      at Context.<anonymous> (test/sort.spec.ts:608:12)
      at processImmediate (internal/timers.js:464:21)

[snovakovic]

@pkit thanks for commenting it. Yes it seams the test are failing in new version of NODE... In NODE version 10 they are passing but failing on NODE 14.... Seams there has been some updates to native sort function and that change how the null/undefined are been sorted... Will reopen this issue and try to get to it today/tomorrow so that test are passing no matter on which version of node they are running.