Changed setup.py file so this package could be installed via pip

snowballstem / pystemmer

Python stemming library using snowball stemmers

https://snowballstem.org/

Other

245 stars 46 forks source link

Changed setup.py file so this package could be installed via pip #17

Closed avikam-pagaya closed 5 years ago

avikam-pagaya commented 6 years ago

Added a new distuils command, bootstrap, based on the code that automatically downloads the c files (the URL and MD5 can be configured in case you want to reduce the dependency on the hosted files)
Also, python setup.py build command check if the files don't exist and download them as before
Now you can do: pip install git+git://github.com/snowballstem/pystemmer

ojwb commented 6 years ago

Please don't mix whitespace changes with functional changes - it makes reviewing the changes so much harder.

I'd also say it's well past time to stop using MD5, so if we're going to rework this we should really switch to using a checksum which offers better protection.

avikam-pagaya commented 6 years ago

Ok, I reset the whitespace changes (Please note you can ignore whitespace changes while you review). I don't see the reason behind coupling the usage of MD5 with the ability to install this package from PIP (it can be solved independently)

BTW, the tests are now failing because the zip file is not available right now. I would consider hosting the code in this repo (as long as the license permits)

ojwb commented 5 years ago

I've cleaned up the code formatting to conform to pep8 (aside from a few overlong lines) in 1300786ad6670c348bbe543ff6f6576a57aea56c, which should address the whitespace changes that were part of this.

Then I've rebuilt the changes proposed here on top of current master and opened #25 for them, so closing this in favour of that.