The tests need to pass for all programming languages, but currently this fails the tests for C (try make check), Ada and Rust and passes for C#, Java, Javascript, Python and Ruby.
(The Pascal backend currently only supports iso-8859-1 and I wasn't able to test Go as there's something up with my local Go setup.)
The pattern here is that it's failing for languages that use UTF-8 and working for those that use wide characters. I'll comment on a line of code where I think the problem is.
The CI should have shown this, but it hasn't run for this PR. I'm not sure why not as it ran for a push I just made to master, and "Build pushed pull requests" is on in the travis-ci settings. I'll try to get that fixed, but meanwhile please try to run at least the C tests locally (they shouldn't need anything beyond what you must have installed to have built the snowball compiler).
The tests need to pass for all programming languages, but currently this fails the tests for C (try
make check
), Ada and Rust and passes for C#, Java, Javascript, Python and Ruby.(The Pascal backend currently only supports iso-8859-1 and I wasn't able to test Go as there's something up with my local Go setup.)
The pattern here is that it's failing for languages that use UTF-8 and working for those that use wide characters. I'll comment on a line of code where I think the problem is.
The CI should have shown this, but it hasn't run for this PR. I'm not sure why not as it ran for a push I just made to master, and "Build pushed pull requests" is on in the travis-ci settings. I'll try to get that fixed, but meanwhile please try to run at least the C tests locally (they shouldn't need anything beyond what you must have installed to have built the snowball compiler).