search

snowblink14 / smatch

Smatch tool: evaluation of AMR semantic structures
MIT License
63 stars 25 forks source link

Update README and CHANGELOG #24

Closed goodmami closed 4 years ago

goodmami commented 4 years ago

This expands the README.md with more information and links, and renames and reformats update_log to CHANGELOG.md. It also adds PyPI project classifiers and metadata so the README is properly rendered at https://pypi.org/project/smatch/.

Notes:

goodmami commented 4 years ago

Thanks for the review. I've resolved your comments.

goodmami commented 4 years ago

Thanks!

You might want to sync with @danielhers on the submission order regarding #23.

As soon as #23 is merged I will rebase. The changes are trivial, I think.

goodmami commented 4 years ago

I just noticed I had the order of "test" and "gold" backwards in the new README, which is now fixed in the last commit.

@danielhers: @snowblink14 said I should coordinate with you on merging #23. I'm happy to rebase my branch after yours is merged. If it's ready to go, can you merge or does @snowblink14 need to?

danielhers commented 4 years ago

I don't have push access to this repository. @snowblink14, could you merge

23 please?

tir. 7. jan. 2020 03.54 skrev Michael Wayne Goodman < notifications@github.com>:

I just noticed I had the order of "test" and "gold" backwards in the new README, which is now fixed in the last commit.

@danielhers https://github.com/danielhers: @snowblink14 https://github.com/snowblink14 said I should coordinate with you on merging #23 https://github.com/snowblink14/smatch/pull/23. I'm happy to rebase my branch after yours is merged. If it's ready to go, can you merge or does @snowblink14 https://github.com/snowblink14 need to?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snowblink14/smatch/pull/24?email_source=notifications&email_token=AACAJQ6B2VO6ZENZJNGK6NDQ4PVG7A5CNFSM4J7IOGY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHQQUY#issuecomment-571410515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAJQZCLL2TYK4N6YQDD33Q4PVG7ANCNFSM4J7IOGYQ .

snowblink14 commented 4 years ago

I don't have push access to this repository. @snowblink14, could you merge #23 please? tir. 7. jan. 2020 03.54 skrev Michael Wayne Goodman < notifications@github.com>: … I just noticed I had the order of "test" and "gold" backwards in the new README, which is now fixed in the last commit. @danielhers https://github.com/danielhers: @snowblink14 https://github.com/snowblink14 said I should coordinate with you on merging #23 <#23>. I'm happy to rebase my branch after yours is merged. If it's ready to go, can you merge or does @snowblink14 https://github.com/snowblink14 need to? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24?email_source=notifications&email_token=AACAJQ6B2VO6ZENZJNGK6NDQ4PVG7A5CNFSM4J7IOGY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHQQUY#issuecomment-571410515>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAJQZCLL2TYK4N6YQDD33Q4PVG7ANCNFSM4J7IOGYQ .

Just merged #23.

goodmami commented 4 years ago

@snowblink14 ok, this is now rebased to the current master branch. There were no conflicts in the end, but since @danielhers partially removed Python 2 support in his PR, I went ahead and removed some now unused imports in setup.py in the last commit.

snowblink14 commented 4 years ago

Shall I merge this? @goodmami

goodmami commented 4 years ago

@snowblink14 sure, i've kept it fresh so anytime is good. In any case, I just fixed a link in the CHANGELOG.md and added a new entry for the latest merge, but these are just documentation changes.