search

snowblink14 / smatch

Smatch tool: evaluation of AMR semantic structures
MIT License
63 stars 27 forks source link

Fix Python 3 support #27

Closed goodmami closed 4 years ago

goodmami commented 4 years ago

The previous commit introduced some syntax that is invalid for Python 3. Smatch had effectively dropped support for Python 2 when #23 was merged (Python 2 still worked but was not tested), so this puts Smatch in an awkward position where it's not really valid for any Python version. This PR removes the offending syntax and thus fixes Python 3 support. This PR does not remove Python 2 support (even though it's not tested), but I think that step should probably happen soon as Python 2 has been retired (well, it got a 4-month reprieve; see http://pyfound.blogspot.com/2019/12/python-2-sunset.html).

This PR also fixes smatch-table.py, which did not really work at all. In addition to making it work for Python 3, I also fixed 2 other bugs I found. But if it hasn't worked for a while now, maybe it should just be removed?

snowblink14 commented 4 years ago

Thanks for fixing this! Not sure if anyone is still using smatch-table, it basically provides support to compute inter rater agreements, but won't scale much..