search

snowblink14 / smatch

Smatch tool: evaluation of AMR semantic structures
MIT License
63 stars 27 forks source link

Add smatch to PyPI #5

Closed mpertierra closed 6 years ago

mpertierra commented 7 years ago

@snowblink14

nschneid commented 7 years ago

And/or NLTK?

mpertierra commented 7 years ago

@nschneid What do you mean? NLTK is already in PyPI (https://pypi.python.org/pypi/nltk). Also, NLTK is not a dependency of smatch.

nschneid commented 7 years ago

I meant that perhaps smatch should be added to NLTK.

mpertierra commented 7 years ago

@nschneid oh I see, that would be nice. I don't know how likely it is that it would be accepted, as this would be the first AMR-related module in NLTK.

nschneid commented 7 years ago

Having contributed modules to NLTK, I think they would be open to well-designed and well-documented AMR functionality. It would take some work to adapt the current smatch code, e.g., to make it compatible with Python 3.x as well as 2.7.

nschneid commented 7 years ago

I have considered contributing my API for reading AMRs to NLTK, but haven't had the time to make it happen. It might also make sense to reimplement smatch using this API, if someone wants to volunteer. :)

mpertierra commented 7 years ago

@nschneid That sounds like a good idea. By the way, have you tried using penman ?

nschneid commented 7 years ago

Haven't used it—my understanding is there is some overlap in functionality between the two APIs, but there are also some things that each supports but the other doesn't. Might be worth incorporating elements of both into NLTK.

snowblink14 commented 7 years ago

Looks like we have 3 requests: 1) Add smatch to PyPI/NLTK 2) Make the code Python 3.x compatible 3) Reimplement smatch using @nschneid's AMR reading API

All should be nice improvements. I'll see what I can do and help is always welcome.

mpertierra commented 7 years ago

@snowblink14 This is a good tutorial to adding a package to PyPI (http://peterdowns.com/posts/first-time-with-pypi.html).

danielhers commented 6 years ago

@snowblink14 I think (1) is the highest priority. I think most people using Python today much prefer installing packages with pip rather than having to clone a github repository.

snowblink14 commented 6 years ago

@danielhers Thanks for uploading smatch to PyPI and making the setup.py! My PyPI username is shucai. Can you add me to the project? And I'll merge setup.py soon.