GarageDoorOpenerAdvanced.js

snowdd1 / homebridge-knx

KNX platform shim for homebridge

https://github.com/nfarina/homebridge

GNU General Public License v2.0

97 stars 56 forks source link

Closed c-o-m-m-a-n-d-e-r closed 4 years ago

c-o-m-m-a-n-d-e-r commented 5 years ago

Hey, in the GarageDoorOpenerAdvanced.js File in Line 464 ... i think it must be

if (field === "KNXDoorClose") {

or not ?

giase82 commented 5 years ago

Hi,

I don't think so... The field in the example below is: { "Type": "KNXDoorClosed", "Listen": "2/3/2", "DPT": "DPT1" },

Do I missunderstand your question?

//Christof

giase82 commented 5 years ago

However, I agree this is inconsistent with KNXDoorOpen. One could fix it the one or the other way around.

c-o-m-m-a-n-d-e-r commented 5 years ago

I know this was in the Example ... but i was debugging the process an the Type "KNXDoorClosed" was never get called.

After changing the Type to "KNXDoorClose" without the "d" and changing Line 464 everything was working fine.

giase82 commented 4 years ago

Sorry for that. Fixed it. Struggling with the git-magic right now for creating branches, commit etc

snowdd1 commented 4 years ago

Hi @giase82 , I think @c-o-m-m-a-n-d-e-r Paul already fixed that in PR https://github.com/snowdd1/homebridge-knx/pull/158 Right?

giase82 commented 4 years ago

Yes! Sorry I did forget ;)

snowdd1 commented 4 years ago

closed with #158