Open ctschach opened 4 years ago
Hi Carsten, that is great! However, it seems to be based on v0.3.19 instead of the current master, and that is why the file compare shows ancient artifacts, like the AccConstructor, which was the historic name back when it was a part of HAP-nodejs, long before Homebridge.
Could you try to re-base the pull request to the newest master? I found that here: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request but I recommend making multiple backup copies in different physical locations :-)
Besides that, I really like it!
Hmmm..this is pretty strange. I pulled the current version from "your" Github version and compared it file by file with "my" version. Everything looks pretty okay.
But I'll have a look at the Rebase and see if I can get this to work.
Year, I think Git remembers when you forked the branch and bases everything on that version. So even if your files are identical to the current master, it will show the differences to 0.3.19 or whatever the base version was.
The following changes have been added:
I'm still a big confused why the file comparison how things like:
var AccConstructor = require('./lib/knxdevice.js'); .vs. var KNXDevice = require('./lib/knxdevice.js');
In the current master's index.js it says KNXDevice and so it does in my index.js. No idea where this AccConstructor comes from.