snowdd1 / homebridge-knx

KNX platform shim for homebridge
https://github.com/nfarina/homebridge
GNU General Public License v2.0
97 stars 56 forks source link

First implementation of Busch Jaeger Waveline Aktors #97

Closed ctschach closed 7 years ago

snowdd1 commented 7 years ago

The contact sensor just responses with 0 closed and >1 open? Why do you first calculate knxValue/255*100 before comparing to ZERO?

ctschach commented 7 years ago

You are absolutely right...this is not needed.I just removed it...

snowdd1 commented 7 years ago

Did the timeout help with the answers? Is it tested and ready to merge?

ctschach commented 7 years ago

Yes, the timeout helped to update the TargetPosition back to CurrentPosition. And yes, it's tested and working on my end...