search

snowdriftcoop / snowdrift

Infrastructure for Snowdrift.coop. This is a MIRROR of https://gitlab.com/snowdrift/snowdrift. Your issue reports and merge requests are welcome, but they will be moved to gitlab.com. You are encouraged to start there instead!
https://snowdrift.coop
GNU Affero General Public License v3.0
92 stars 36 forks source link

/t pulling tickets from GitHub includes pull requests #228

Closed wolftune closed 7 years ago

wolftune commented 10 years ago

Pull requests are not really issues and probably shouldn't be included in our /t listings

dlthomas commented 10 years ago

Hey, didn't notice this. Interesting! I think we should show pull requests on /t (GT pull requests too!), but of course not as tickets. Ideally we could even examine the log and note referenced tickets.

On Wed, Jan 15, 2014 at 9:28 AM, Aaron Wolf notifications@github.comwrote:

Pull requests are not really issues and probably shouldn't be included in our /t listings

— Reply to this email directly or view it on GitHubhttps://github.com/dlthomas/snowdrift/issues/228 .

wolftune commented 10 years ago

Hmm, definitely if we can pull in "merge requests" (as Gitorious calls them) and actually recognize when they reference SD tickets, that would be pretty awesome.

dlthomas commented 10 years ago

In principle, we certainly can - worst case, we can submit a patch if we need something GT doesn't expose.

In practice it's a question of when it becomes a priority...

On Wed, Jan 15, 2014 at 9:58 AM, Aaron Wolf notifications@github.comwrote:

Hmm, definitely if we can pull in "merge requests" (as Gitorious calls them) and actually recognize when they reference SD tickets, that would be pretty awesome.

— Reply to this email directly or view it on GitHubhttps://github.com/dlthomas/snowdrift/issues/228#issuecomment-32390920 .

dlthomas commented 10 years ago

(so support things that deal with pull/merge requests, but tickets can be GH-only without guilt)

On Wed, Jan 15, 2014 at 10:04 AM, David Thomas davidleothomas@gmail.comwrote:

I would like to make sure we keep our support of GT at least on par with GH, where GT has the relevant features.

On Wed, Jan 15, 2014 at 10:03 AM, David Thomas davidleothomas@gmail.comwrote:

In principle, we certainly can - worst case, we can submit a patch if we need something GT doesn't expose.

In practice it's a question of when it becomes a priority...

On Wed, Jan 15, 2014 at 9:58 AM, Aaron Wolf notifications@github.comwrote:

Hmm, definitely if we can pull in "merge requests" (as Gitorious calls them) and actually recognize when they reference SD tickets, that would be pretty awesome.

— Reply to this email directly or view it on GitHubhttps://github.com/dlthomas/snowdrift/issues/228#issuecomment-32390920 .

dlthomas commented 10 years ago

I would like to make sure we keep our support of GT at least on par with GH, where GT has the relevant features.

On Wed, Jan 15, 2014 at 10:03 AM, David Thomas davidleothomas@gmail.comwrote:

In principle, we certainly can - worst case, we can submit a patch if we need something GT doesn't expose.

In practice it's a question of when it becomes a priority...

On Wed, Jan 15, 2014 at 9:58 AM, Aaron Wolf notifications@github.comwrote:

Hmm, definitely if we can pull in "merge requests" (as Gitorious calls them) and actually recognize when they reference SD tickets, that would be pretty awesome.

— Reply to this email directly or view it on GitHubhttps://github.com/dlthomas/snowdrift/issues/228#issuecomment-32390920 .

wolftune commented 10 years ago

I think now that keeping PR in the list is fine if they somehow get marked as PR. Right now, the title is all we see so it looks like any other ticket. If it can be marked clearly, I could see it being useful for developers looking over their tasks.