search

snowdriftcoop / snowdrift

Infrastructure for Snowdrift.coop. This is a MIRROR of https://gitlab.com/snowdrift/snowdrift. Your issue reports and merge requests are welcome, but they will be moved to gitlab.com. You are encouraged to start there instead!
https://snowdrift.coop
GNU Affero General Public License v3.0
92 stars 36 forks source link

adds a header to user_balance and user_pledges #193 #294

Closed rdesfo closed 9 years ago

chreekat commented 9 years ago

Hey, thanks for the patch!

Unfortunately, <center> is deprecated in HTML5. Could you use CSS instead? @wolftune or @jazzyeagle might have specific suggestions.

wolftune commented 9 years ago

Yeah, the not-so-great but works for now version instead of <h1><center> use this: <h1 .text-center> (that uses Bootstrap classes and hamlet syntax). Really, our ideal would be to use classes that are more meaningful for the use case and then have real CSS settings that affect all of these, but the solution I just mentioned is what we've used for now.

rdesfo commented 9 years ago

OK... I'll correct it and resubmit. There are a few other templates using the center tag. I'll update them in another patch as well.

I noticed that the style guide recommends 2 spaces for hamlet files. But all the hamlet files I looked at still use 4 spaces. Would you guys prefer the 2 or 4 spaces?

chreekat commented 9 years ago

2 is a new recommendation, but all existing files have 4. It's just a recommendation, and files don't have to be updated. The only required thing is to be consistent within a particular file.

If you do feel inclined to change a file from 4 spaces to 2, please do it in a single commit, such that "git diff -b" shows no differences. Alternatively, just ask me to do it... I have some vim functions that make it take me about 3 seconds.

On Fri, Apr 03, 2015 at 01:23:55PM -0700, Ryan wrote:

OK... I'll correct it and resubmit. There are a few other templates using the center tag. I'll update them in another patch as well.

I noticed that the style guide recommends 2 spaces for hamlet files. But all the hamlet files I looked at still use 4 spaces. Would you guys prefer the 2 or 4 spaces?

— Reply to this email directly or view it on GitHub.*

rdesfo commented 9 years ago

I'll just use the spacing convention the file has and let you run your vim scripts when you want to change the spacing.