snowdriftcoop / snowdrift

Infrastructure for Snowdrift.coop. This is a MIRROR of https://gitlab.com/snowdrift/snowdrift. Your issue reports and merge requests are welcome, but they will be moved to gitlab.com. You are encouraged to start there instead!
https://snowdrift.coop
GNU Affero General Public License v3.0
92 stars 36 forks source link

Snowdrift doesn't support base-4.8 #298

Closed pharpend closed 9 years ago

pharpend commented 9 years ago

I tried to compile Snowdrift today, we don't support the newest base.

I removed the cabal.config file, ran cabal install -j --enable-tests, and this is the output:

Resolving dependencies...
cabal: Could not resolve dependencies:
trying: Snowdrift-0.1.2 (user goal)
trying: base-4.8.0.0/installed-1b6... (dependency of Snowdrift-0.1.2)
next goal: titlecase (dependency of Snowdrift-0.1.2)
rejecting: titlecase-0.1.0.0 (conflict: base==4.8.0.0/installed-1b6...,
titlecase => base>=4.7 && <4.8)
Dependency tree exhaustively searched.

I don't know what titlecase does, but I'm guessing it's similar to toTitle from Data.Text. Could we try to switch to that, for compatibility reasons?

chreekat commented 9 years ago

Well, it probably does, but its dependencies do not. :) I suggest opening an issue on titlecase.

pharpend commented 9 years ago

I fixed titlecase on my own machine, sent a pull request to @nkaretnikov.

pharpend commented 9 years ago

@chreekat I should have mentioned, even after I fixed titlecase, there are a suite of other packages that failed, so this shouldn't be closed.

chreekat commented 9 years ago

Good point, may as well leave it open until all deps are good to go.

nkaretnikov commented 9 years ago

I released a new version of titlecase. Please let me know if there are any issues.

nkaretnikov commented 9 years ago

No, toTitle from text is not what we want since it capitalizes every word. Moreover, it behaves undesirably in certain cases (see the documentation). For example:

Prelude> :l Data.Text.Titlecase
*Data.Text.Titlecase> :set -XOverloadedStrings
*Data.Text.Titlecase> titlecase "snowdrift.coop"
Titlecase {unTitlecase = "Snowdrift.coop"}
*Data.Text.Titlecase> import qualified Data.Text as Text
*Data.Text.Titlecase Text> Text.toTitle "snowdrift.coop"
"Snowdrift.Coop"
pharpend commented 9 years ago

The current issue is the github library. I sent them a PR which supports base-4.8: https://github.com/jwiegley/github/pull/100 .

Once that gets merged, the next target is yesod-markdown. I will work on fixing that.

pharpend commented 9 years ago

Update on this: once #308 gets merged, this will be solved. Until then, I suggest those wanting base-4.8 support use my master branch.

pharpend commented 9 years ago

Stack fixed this!

chreekat commented 9 years ago

Yaaaas On Aug 13, 2015 9:01 PM, "Peter Harpending" notifications@github.com wrote:

Stack fixed this!

— Reply to this email directly or view it on GitHub https://github.com/snowdriftcoop/snowdrift/issues/298#issuecomment-130958902 .