Closed pharpend closed 9 years ago
Well, it probably does, but its dependencies do not. :) I suggest opening an issue on titlecase.
I fixed titlecase on my own machine, sent a pull request to @nkaretnikov.
@chreekat I should have mentioned, even after I fixed titlecase, there are a suite of other packages that failed, so this shouldn't be closed.
Good point, may as well leave it open until all deps are good to go.
I released a new version of titlecase
. Please let me know if there are any issues.
No, toTitle
from text
is not what we want since it capitalizes every word. Moreover, it behaves undesirably in certain cases (see the documentation). For example:
Prelude> :l Data.Text.Titlecase
*Data.Text.Titlecase> :set -XOverloadedStrings
*Data.Text.Titlecase> titlecase "snowdrift.coop"
Titlecase {unTitlecase = "Snowdrift.coop"}
*Data.Text.Titlecase> import qualified Data.Text as Text
*Data.Text.Titlecase Text> Text.toTitle "snowdrift.coop"
"Snowdrift.Coop"
The current issue is the github
library. I sent them a PR which supports base-4.8: https://github.com/jwiegley/github/pull/100 .
Once that gets merged, the next target is yesod-markdown
. I will work on fixing that.
Update on this: once #308 gets merged, this will be solved. Until then, I suggest those wanting base-4.8 support use my master branch.
Stack fixed this!
Yaaaas On Aug 13, 2015 9:01 PM, "Peter Harpending" notifications@github.com wrote:
Stack fixed this!
— Reply to this email directly or view it on GitHub https://github.com/snowdriftcoop/snowdrift/issues/298#issuecomment-130958902 .
I tried to compile Snowdrift today, we don't support the newest base.
I removed the cabal.config file, ran
cabal install -j --enable-tests
, and this is the output:I don't know what
titlecase
does, but I'm guessing it's similar totoTitle
fromData.Text
. Could we try to switch to that, for compatibility reasons?