snowdriftcoop / snowdrift

Infrastructure for Snowdrift.coop. This is a MIRROR of https://gitlab.com/snowdrift/snowdrift. Your issue reports and merge requests are welcome, but they will be moved to gitlab.com. You are encouraged to start there instead!
https://snowdrift.coop
GNU Affero General Public License v3.0
92 stars 36 forks source link

User is confusingly redirected to /auth/login after inputting an invalid token #331

Closed sayoder closed 7 years ago

sayoder commented 7 years ago

Hi, I'm just getting familiar with this codebase (got pointed here from CodeTriage) and hoping to tackle #144. I noticed when I first created a test account that inputting an invalid authentication token redirected me to /auth/login, upon which I had to use my browser "back" button to get back to /auth/verify-account and input the correct token. Obviously this is not a huge issue, but it's awkward from a UI perspective.

Steps to reproduce:

In my opinion, the ideal behavior here would be just to redirect to /auth/verify-account (and display the yellow box and concerned dog) until the user manages to enter the correct token. Thoughts?

Edit: Since this is such a small change, I'm going to close this issue and put in a pull request. Then you can just dump it if it's not what you have in mind.