search

snowdriftcoop / snowdrift

Infrastructure for Snowdrift.coop. This is a MIRROR of https://gitlab.com/snowdrift/snowdrift. Your issue reports and merge requests are welcome, but they will be moved to gitlab.com. You are encouraged to start there instead!
https://snowdrift.coop
GNU Affero General Public License v3.0
92 stars 36 forks source link

Redirect user to /auth/verify-account after inputting an invalid token #332

Closed sayoder closed 7 years ago

sayoder commented 7 years ago

As discussed in #331.

chreekat commented 7 years ago

Awesome, thanks! I think this is the right idea.

Incidentally, a related feature that would be nice to have is the following:

After successful login, if the referrer URL is from the same site, then redirect to that URL rather than to HomeR. This allows pages on the site to require login, which redirects the user to log in... right now they get booted to HomeR instead of going back to the page that required login in the first place.

sayoder commented 7 years ago

Great! I've spent the last few hours gaining a bit more familiarity with Yesod and this codebase. Yesod is a strange framework to dive headfirst into...

That behavior sounds good - Do you think the ideal way to pass that info along would be through Yesod's setSession and lookupSession cookie operations?

chreekat commented 7 years ago

Actually I think it is already in the http headers. I am not positive. Otherwise, yeah, doing something with the session should be good.

You can crib off yesod-auth, which has a similar (but broken) mechanism that redirects to the referrer ALWAYS. This caused people to get redirected away from the site sometimes...

On Wed, Nov 30, 2016 at 02:33:07PM -0800, Seth Yoder wrote:

Sounds good - Do you think the ideal way to pass that info along would be through Yesod's setSession and lookupSession cookie operations?

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/snowdriftcoop/snowdrift/pull/332#issuecomment-264018033