snowdrop-zen / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
1 stars 0 forks source link

Generated Openshift manifest contains malformed value of app.openshift.io/vcs-url and app.quarkus.io/vcs-url annotations #259

Closed snowdrop-bot closed 3 years ago

snowdrop-bot commented 3 years ago

Describe the bug Openshift manifest generated by the Quarkus 1.11.1 contains malformed url of the git repo when ssh is used.

Expected behavior Openshift manifest generated by the Quarkus contains value provided by git like ssh://git@fqhn:port/path/repo.git

Actual behavior Actual value in the generated manifest https://fqhn/port/path/repo.git

To Reproduce

mvn clean package on a Quarkus project where the remote repo is accessed over ssh then check the generated Openshift Manifests in target/kubernetes/openshift.[yml|json]

Result of git remote -v

git remote -v
origin  ssh://git@hostname.subdomain.domain.tld:7999/path/repo-name.git (fetch)
origin  ssh://git@hostname.subdomain.domain.tld:7999/path/repo-name.git (push)
upstream        ssh://git@hostname.subdomain.domain.tld:7999/path/repo-name.git (fetch)
upstream        ssh://git@hostname.subdomain.domain.tld:7999/path/repo-name.git (push)

Configuration

config_suffix=-t

quarkus.application.name=application-name${config_suffix}

quarkus.kubernetes.deployment-target=openshift
quarkus.openshift.env.configmaps=config-map${config_suffix}
quarkus.openshift.env.secrets=truststore-password,keystore-passwords
quarkus.openshift.mounts.keystore.path=/mnt/keystore
quarkus.openshift.mounts.truststore.path=/mnt/truststore
quarkus.openshift.secret-volumes.truststore.secret-name=some-truststore
quarkus.openshift.secret-volumes.keystore.secret-name=keystore
quarkus.openshift.service-account=default

quarkus.openshift.resources.requests.memory=100Mi
quarkus.openshift.resources.requests.cpu=50m
quarkus.openshift.resources.limits.memory=250Mi
quarkus.openshift.resources.limits.cpu=100m

Screenshots (If applicable, add screenshots to help explain your problem.)

Environment (please complete the following information):

Additional context


https://github.com/quarkusio/quarkus/issues/14827


$upstream:14827$