snowdrop-zen / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
1 stars 0 forks source link

QuarkusIntegrationTest: docker option --net=host not supported for windows #384

Closed snowdrop-bot closed 3 years ago

snowdrop-bot commented 3 years ago

In Quarkus 2.1.0 the docker run command has changed to bind to the host network instead. This property, however, is invalid on windows (and mac?). Nor does this work properly if the container is started from another container (for example on our gitlab runner).

https://github.com/quarkusio/quarkus/blob/d0555c781c15cbc684684b3d79f98f2507658a94/test-framework/common/src/main/java/io/quarkus/test/common/DefaultDockerContainerLauncher.java#L81

Obviously the old behavior had major issues as well, so I thought of a solution that will work in all cases:

Why not run the docker image (containing the application) using testcontainers as well?

When running the testcontainer containing the application, we would provide the second set of values while all others receive the first set.


https://github.com/quarkusio/quarkus/issues/18914


$upstream:18914$