Missing permissions for webhook deployment

snowdrop / godaddy-webhook

Cert Manager Godaddy Webhook performing ACME challenge using DNS record

Apache License 2.0

72 stars 62 forks source link

Missing permissions for webhook deployment #44

Closed fuero closed 4 months ago

fuero commented 4 months ago

The helm chart generated godaddy-webhook clusterrole is missing this rule to work (tested on OpenShift 4.15):

- apiGroups:                                                                                                                                                                                      
  - ""                                                                                                                                                                                            
  resources:                                                                                                                                                                                      
  - configmaps                                                                                                                                                                                    
  verbs:                                                                                                                                                                                          
  - get                                                                                                                                                                                           
  - watch                                                                                                                                                                                         
  - list

cmoulliard commented 4 months ago

Many thanks for reporting this. Can you propose a PR please ?

fuero commented 4 months ago

See #46

cmoulliard commented 4 months ago

PR merged