search

snowdrop / godaddy-webhook

Cert Manager Godaddy Webhook performing ACME challenge using DNS record
Apache License 2.0
74 stars 63 forks source link

Misleading cluster issuer example #45

Closed fuero closed 5 months ago

fuero commented 5 months ago

The example clusterIssuer has a selector that's only valid for issuing a wildcard certificate.

I propose changing the example from:

selector:
  dnsNames:
   - "*.example.com"

to:

selector:
  dnsZones:
   - "example.com"
cmoulliard commented 5 months ago

Many thanks for reporting this and good catch. Can you propose a PR please ?

fuero commented 5 months ago

See #47

fuero commented 5 months ago

I've also added a clarifying comment about the groupName parameter that puzzled me - I thought that had something to do with the GoDaddy API itself.

cmoulliard commented 5 months ago

PR merged