snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

0.8.1 #11

Closed avalcepina closed 6 years ago

avalcepina commented 6 years ago

We tried to allow for creating or replacing istio custom resources (instead of just creating). The change works but it's probably not the best way to achieve this result. A better way would be to just use the standard Function class from the kubernetes client in DoneableIstioResource instead of the generated one ( that should work, although I have been unable to test it). Please let us know if you have any suggestion on how to achieve this result or if you think this change is fine as it is.

avalcepina commented 6 years ago

Closing because of better solution in Change builder name to make replace work