search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

istio.common and istio.model package “me.snowdrop.istio.api” is duplicate #112

Closed iwangxiaodong closed 2 years ago

iwangxiaodong commented 4 years ago

Hello:

istio.common and istio.model package “me.snowdrop.istio.api” is duplicate

JDK9+ module system is not supported!!!

Thanks!

@metacosm

metacosm commented 4 years ago

@iwangxiaodong Could you elaborate please? How does that manifest? We made the choice to stay on Java 8 for the moment.

iwangxiaodong commented 4 years ago

@metacosm

Just change package name.

Keep istio.model package，change istio.common package “me.snowdrop.istio.api” to “me.snowdrop.istio.common.api” ...

compatible JDK8 and JDK9+ (JPMS)

metacosm commented 4 years ago

I meant, how does that manifest itself in your code?

iwangxiaodong commented 4 years ago

enabled JPMS(module-info.java):

error: module my.module reads package me.snowdrop.istio.api from both istio.common and istio.model

iwangxiaodong commented 4 years ago

I will close this issue, waiting for future JDK9+JPMS, your official support.

metacosm commented 4 years ago

Let's leave it open to keep it on the radar but it's not currently a priority…

iwangxiaodong commented 4 years ago

Sure.

Gefuxing commented 4 years ago

哈哈