search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Add Json Deserializer for PortSelector #27

Closed bgokden closed 6 years ago

bgokden commented 6 years ago

I saw your fix for StringMatch and I decided same deserialiser can be used for PortSelector. Although Port selector can be "name" or "number" in protobuf definition, only number is documented. I think only number is supported as well.

metacosm commented 6 years ago

Thank you. I'm working on this part, actually, trying to make it easier to detect and support cases like this. I will merge this now but how things are implemented might actually change soon-ish… :)

bgokden commented 6 years ago

Thank you.

metacosm commented 6 years ago

@bgokden I've pushed the start of an easier, semi-automated support for interface types and have thus refactored your PortSelector support. You'll see that it should be simpler now to add support for "interfaces" field. I will add support for the other ones probably tomorrow.

bgokden commented 6 years ago

@metacosm thank you, we will refactor our code base once you finish.