search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Simplify CircleCI configuration #33

Closed geoand closed 6 years ago

geoand commented 6 years ago

Fixes: #32

geoand commented 6 years ago

The build is failing but the again so does make in master. Is that to be expected @metacosm ?

metacosm commented 6 years ago

I’ll check, it might be expected since things are under heavy changes at the moment.

Le 7 sept. 2018 à 16:57, Georgios Andrianakis notifications@github.com a écrit :

The build is failing but the again so does make in master. Is that to be expected @metacosm ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

geoand commented 6 years ago

Ok, cool

metacosm commented 6 years ago

master builds on my system but I'm using go 1.11. vendor is up to date as well.

geoand commented 6 years ago

Using go version go1.10.3 linux/amd64 when performing make off of master, I got:

vendor/github.com/gogo/protobuf/proto/lib.go:917:13: undefined: marshalInfo
vendor/github.com/gogo/protobuf/proto/lib.go:918:13: undefined: unmarshalInfo
vendor/github.com/gogo/protobuf/proto/lib.go:919:13: undefined: mergeInfo
vendor/github.com/gogo/protobuf/proto/lib.go:920:13: undefined: discardInfo
geoand commented 6 years ago

Closing since going down this route would make the configuration more complex than it is in the master branch

metacosm commented 6 years ago

Any reason to keep the branch around?

geoand commented 6 years ago

Nope, deleting it