search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Add "Spec" suffix to CRD classes. #43

Closed metacosm closed 5 years ago

metacosm commented 5 years ago

UNTESTED!

geoand commented 5 years ago

Should we perhaps create more ITs for the purpose of testing this refactoring?

metacosm commented 5 years ago

We can always create more tests… :)

geoand commented 5 years ago

Do we have any suspicions of which resources my need more attention due to the refactoring or just because they are suspicious in general?

metacosm commented 5 years ago

Not any in particular… ideally, we'd cover everything but the issue there is that each time the API changes, the tests need to be updated which is less than ideal because you're basically left without the safety net during the refactoring… :( Ideally, we'd devise a way to test things end to end without relying so much on the API…

geoand commented 5 years ago

That is indeed a concern, but if we don't use the API in the tests we can't really test things end-to-end. Plus I would add that the integration tests also act as example use cases

metacosm commented 5 years ago

Indeed, testing likely user use cases would be great.

geoand commented 5 years ago

I will go over the istio boosters and add use cases that we have there, but other than that, I'm not really sure what the most common use cases are :P

I guess we could also take a look at the examples Istio has