snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

refactor: Merge old client with new. #45

Closed iocanel closed 5 years ago

geoand commented 5 years ago

@iocanel Would you mind rebasing onto master? I just added another IT

iocanel commented 5 years ago

done

geoand commented 5 years ago

Thanks!

geoand commented 5 years ago

@iocanel I have changed the CircleCI configuration to build pull requests from forked repos. So if you want to see the tests run, please go ahead and force push

metacosm commented 5 years ago

@geoand not sure I understand your last comment… Not merging before we see a test run, though.

geoand commented 5 years ago

By default CircleCI won't test pull requests whose repo is a fork of the original, hence the absence of any CircleCI traces in this PR. I have changed the configuration in the CircleCI dashboard, so if the PR is updated we should see it being built