search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Remove dependency on com.sun:tools #54

Closed AsCat closed 5 years ago

AsCat commented 5 years ago

Remove dependency 'com.sun:tools' which cause 'Missing artifact com.sun.java:tools:jar' in maven compile process when JDK 9 or higher version

geoand commented 5 years ago

@iocanel is this something that would affect sundrio?

iocanel commented 5 years ago

Possibly! Need to check why sundrio depends on that.

AsCat commented 5 years ago

As tested in jdk 1.8, everything looks fine without any error. In latest sundrio prepare release version 0.14.1, tools.jar dependency is removed in JDK >= 9; Merge pull request #118 from k-wall/issue-117-toolsjar And I edited my PR using maven profile, only remove the tool.jar when jdk >=9, which may has better compatibility;

Of course, another solution is that we can wait for the next sundrio release version;

metacosm commented 5 years ago

@AsCat can you rebase from master, please? Also, I've tried to build this branch on Java 10 and it doesn't work but the fix is easy: you need to upgrade Lombok to the latest version (1.18.2). Can you please make that change as well?

metacosm commented 5 years ago

Actually, I've upgraded master as well. So merging this. Thank you! By the way, sundrio 0.14 doesn't fix the issue by itself anyway.