search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Bugfix in deserializer when processing enum type #55

Closed AsCat closed 5 years ago

AsCat commented 5 years ago

Fixed a bug when isito yaml contains enum type. For example when adding loadBalancer in destination-rule.yaml config file, it will throw exception as there is no default constructor with enum type(default is String type);

I also fixed the tests and yaml template adding enum type. Can anyone verify this PR?

geoand commented 5 years ago

Thanks @AsCat!

Looks good to me, but I would like @metacosm to approve as well

arief-hidayat commented 5 years ago

I would love to have this available in 1.0.1. Thanks

metacosm commented 5 years ago

Going to check today.

metacosm commented 5 years ago

Thanks a lot!