search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Support redisquota in AdapterDsl #57

Closed jnodorp closed 5 years ago

jnodorp commented 5 years ago

Are the AdapterClient.java and AdapterDsl.java files generated? If not I would like to see redisquota being added here.

If they are generated could you point me in the right direction for providing another PR?

jnodorp commented 5 years ago

Thanks for the fast review! Do you have some kind of CI/CD pipeline in place? If not, would you mind pulling a release?

geoand commented 5 years ago

Thanks for the fast review! Do you have some kind of CI/CD pipeline in place? If not, would you mind pulling a release?

We do have a CI pipeline that checks PRs and commits, but it doesn't create releases on each change to master ( so no CD I guess :P ). @metacosm A release shouldn't be a problem right?

metacosm commented 5 years ago

I was planning on waiting for Istio 1.1 before spinning a release… but I could probably do that tomorrow. @geoand maybe we should investigate putting in place some sort of CD to spin nightlies?

geoand commented 5 years ago

Yeah, that makes sense. We can certainly look into it