search

snowdrop / istio-java-api

A Java API to generate Istio descriptors, inspired by Fabric8's kubernetes-model.
Apache License 2.0
112 stars 33 forks source link

Istio yaml can contain more than one document inside #6

Closed lordofthejars closed 6 years ago

lordofthejars commented 6 years ago

Istio yaml can contain more than one document inside. YAML allows defines more than one document in the same file by separating them with ---.

We need to configure Jackson library to read in that way.

@hemanik can help on this providing some hints on how to do it since she did it in kubernetes client.

metacosm commented 6 years ago

@hemanik can you point me to how to implement this, please? I can probably figure it out myself but it'll go faster if you can point me to the appropriate doc / code / direction! ;)

hemanik commented 6 years ago

@metacosm, here's the PR and the relevant logic for the change.

metacosm commented 6 years ago

Thanks! OK, that's more or less what I was going to do. Was wondering if maybe there was some special Jackson magic to make it work directly (though googling for answers seemed to indicate otherwise).