Notice that method receives one IstioResource instead of a list. I have done in this way because it is important to get the result of the operation (if it has been deleted or not) hence it returns a booelan (this is how the Kuberentes-Client does). The problem is that if I set as a list then I need to return a Map<IstioResource, Boolean> with each of the result, and then the caller needs to check this map to see if there is any false. So instead of complicating things in that way I prefer to just user can set one IstioResource and if it has more than one to delete just do a foreach
metacosm
commented
6 years ago
Notice that method receives one
IstioResourceinstead of a list. I have done in this way because it is important to get the result of the operation (if it has been deleted or not) hence it returns a booelan (this is how the Kuberentes-Client does). The problem is that if I set as a list then I need to return aMap<IstioResource, Boolean>with each of the result, and then the caller needs to check this map to see if there is any false. So instead of complicating things in that way I prefer to just user can set oneIstioResourceand if it has more than one to delete just do a foreach