search

snowdrop / narayana-spring-boot

Narayana Spring Boot autoconfiguration and starter
Apache License 2.0
46 stars 43 forks source link

Generate right-length nodeIdentifier/ XID #132

Closed deepred-dev closed 8 months ago

deepred-dev commented 9 months ago

Generate right-length nodeIdentifier if nodeIdentifier is longer than 28 bytes, the XID generated by narayana ist too long, and and error occurs. This shortens the nodeIdentifier if necessary, while keeping it unique.

Fix ported from quarkus https://github.com/quarkusio/quarkus/issues/30491 https://github.com/quarkusio/quarkus/pull/36752/commits/07b3a4c9fd9e6655bf8b2c8bf186002d539f72ac

geoand commented 8 months ago

Imports look like they are not sorted.

Can you fix that please?

Thanks

deepred-dev commented 8 months ago

Hi, yes of course. But I am currently not in the office. I hopefully can fix it by the end of this week.

Greetings Oliver

On 4. Mar 2024, at 07:27, Georgios Andrianakis @.***> wrote:

 You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Imports look like they are not sorted.

Can you fix that please?

Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/snowdrop/narayana-spring-boot/pull/132#issuecomment-1975822957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQF3ZPVS56UH4TC5DIZC76TYWQH63AVCNFSM6AAAAABC333IFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVHAZDEOJVG4. You are receiving this because you authored the thread.Message ID: @.***>

geoand commented 8 months ago

Thanks!

cmoulliard commented 8 months ago

Can you fix the checkstyle violation please ? 

Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (checkstyle-validation) on project narayana-spring-boot-core: You have 1 Checkstyle violation. -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :narayana-spring-boot-core
graben commented 8 months ago

@geoand: Could you review again?

geoand commented 8 months ago

Mind squashing and rebasing the commits please?