Revert "Generate right-length nodeIdentifier/ XID"

[graben]

Resolves #140

Update to #132/#136/quarkusio/quarkus#30491

[graben]

For MariaDB I can confirm that the shorten transactionManagerId (xa node name) is causing an issue in command XA START. Generated hex String of xid is too long.

@geoand: Maybe hashing approach has drawback also for Quarkus. Should be verified!

[geoand]

So if I understand correctly, you are changing the default behavior to not shorten the ID? Why this change of default (which is a breaking change)?

[graben]

This feature was introduced in the last version 3.1.0 as a back port from Quarkus where it is disabled by default. So I do just add what should be there already. But it seems that this feature has drawbacks anyway in Spring boot and Quarkus which should be evaluated. 😉

[geoand]

Understood, thanks

[graben]

Well, It seems the patch at Quarkus is wrong. SHA-224 creates a 28 sized byte array but after creating a UTF-8 String from it the corresponding byte array is somewhere around size 40-60 much bigger than 28 :-/

[geoand]

Thanks for investigating.

Please open a relevant issue in the Quarkus repo

[graben]

In the meantime I would suggest to revert this feature for a 3.1.1 patch release until a better fix is found.

@geoand : okay for you?

[geoand]

Sounds good to me

[graben]

@geoand : Revert #136 as discussed and opened quarkusio/quarkus#40256 for Quarkus. @jacobdotcosta: Could you plz do a 3.1.1 patch release after merge?

[jacobdotcosta]

I'll release 3.1.1.

[jacobdotcosta]

Relased 3.1.1.Beta1, @graben could you check if it's OK before releasing the final version?

[graben]

Looks good to me, but could really test it tomorrow, okay for you?

[jacobdotcosta]

Sure, no problem. Thanks.

[graben]

@jacobdotcosta: build and tested successfully. Ready to release! ;-)

[jacobdotcosta]

3.1.1 released @graben

[graben]

@jacobdotcosta thx, but don't miss the scm tag 😉

[jacobdotcosta]

fixed :(