search

snowdrop / snowdrop-automation-client

snowdrop-automation-client
Apache License 2.0
1 stars 1 forks source link

Rewrite launcher catalog pr command #85

Closed gytis closed 4 years ago

gytis commented 4 years ago

This does not fix actual PR creation issue yet. However, it introduced abstractions on GitHub, Updater as well as extracts the hardcoded values to the configuration. It also fixes how the example tags are found.

https://github.com/snowdrop/snowdrop-automation-client/issues/84 https://github.com/snowdrop/snowdrop-automation-client/issues/73

gytis commented 4 years ago

I'll just change the indentation back to 2 spaces, since it's the dominant one around the project.

jacobdotcosta commented 4 years ago

LGTM

gytis commented 4 years ago

That's fare enough :) I'm just trying to keep people in the loop.

gytis commented 4 years ago

The main idea is to start abstracting the logic that interacts with GitHub directly under an interface rather than a collection of loose methods. I think this way we might be able to make other parts of the code a little bit cleaner and more testable.