search

snowdrop / spring-boot-bom

Apache License 2.0
4 stars 16 forks source link

Move testsuite into the BOM repository #87

Open gytis opened 4 years ago

gytis commented 4 years ago

Correct me if I'm wrong, but the testsuite is only used to test the BOM, right? So maybe it would be more logical to move it under the same repository as the BOM? What do you think? @cmoulliard @metacosm @geoand @iocanel @aureamunoz @jacobdotcosta

geoand commented 4 years ago

That is correct.

I am not convinced however that moving the testsuite is the best idea

gytis commented 4 years ago

Why not?

geoand commented 4 years ago

I just think the repository should be BOM only. But then again I'm definitely not going to loose any sleep if we do move it in 😂

gytis commented 4 years ago

I think it would be nice to get rid of all the bash magic in the CI configuration. Now we needs to clone, modify the pom.xml in different ways to align the version, build it etc. It might make runs faster too.

We could move all of it to the integration-tests directory. So it shouldn't pollute the repo too much either.

geoand commented 4 years ago

I personally wouldn't do it, but I do see some merit no doubt :). Whatever you prefer.

gytis commented 4 years ago

I'm not married to the idea, just thought of it yesterday while trying to make CI work with 2.2.5. Just wanted to get others input on this.

metacosm commented 4 years ago

I see merits in both points of view. Let's decide on this at the next weekly.

aureamunoz commented 4 years ago

I think I prefer Gytis' proposition but I've not played enought with this to have a strong advice