snowdrop / vertx-spring-boot

Vert.x Spring Boot integration brings different Vert.x components to Spring Boot ecosystem
Apache License 2.0
137 stars 41 forks source link

Execute blocking teardown code in vert.x worker pool #128

Closed Arooba-git closed 1 year ago

Arooba-git commented 1 year ago

Hi! :) Thanks for your effort for this handy project.

Your project does a great job ensuring the event loop remains non-blocking, indeed. However there is a tear down logic in AbstractIT that is blocking, as identified by BlockHound:

vs1-blocking

This PR fixes the code to ensure the event loop remains reactive end to end. We re-ran the test cases and also analyzed the performance (CPU usage) before and after the fix:

Before

vs1-cpu-before

After

vs1-cpu-after