snowex-hackweek / website-2022

Event webpage and Jupyterbook 2022
https://snowex-2022.hackweek.io
MIT License
2 stars 32 forks source link

Swesarr #94

Closed drboyd closed 2 years ago

drboyd commented 2 years ago

porting last year's notebook to main. thanks for the help

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

drboyd commented 2 years ago

quality control seems to be assigning spell errors where there aren't any. also seems to be failing because I didn't clear the kernel output before pushing .... but i did do that?

jomey commented 2 years ago

Looks like you do have output in your notebook: https://github.com/snowex-hackweek/website2022/blob/bc2a76e9783768a9c44f4d2df96fce0f13209223/book/tutorials/microwave/swesarr/swesarr_tut.ipynb

Did you 'save' the notebook after you restarted and cleared all outputs? It's two step process, which can be forgotten

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on this branch

drboyd commented 2 years ago

Looks like you do have output in your notebook: https://github.com/snowex-hackweek/website2022/blob/bc2a76e9783768a9c44f4d2df96fce0f13209223/book/tutorials/microwave/swesarr/swesarr_tut.ipynb

Did you 'save' the notebook after you restarted and cleared all outputs? It's two step process, which can be forgotten

Ah, thanks Jo. Not sure how that happened. It's saved as cleared on my side. I apologize.

drboyd commented 2 years ago

Hi @jomey @scottyhq If I'm reading the error log for _Test / Build and test on OS - ubuntu-latest (pull_requesttarget) right, is it saying that rendering a table is no longer compatible with the hackweek websites?

Exception occurred: File "/usr/share/miniconda3/envs/hackweek/lib/python3.10/site-packages/myst_parser/docutils_renderer.py", line 730, in render_table assert token.children and len(token.children) > 1 AssertionError

At a glance, it looks like some function render_table() in the hackweek library doesn't like one of the tables I've used... Which is likely either xarray or pandas. It still renders on JupyterLab though.

I can try commenting out the code blocks that render any tables. Students can uncomment those blocks during the hackweek painlessly. That's my best hunch for quickly fixing this since it doesn't seem like it's our fault.

scottyhq commented 2 years ago

Sees like this issue. https://github.com/executablebooks/jupyter-book/issues/1525. Likely fixed by newer jupyterbook0.13+dependencies. For the time being I just removed the markdown tables in favor of bold font

github-actions[bot] commented 2 years ago

🚀 Deployed on https://deploy-preview-94--snowex2022.netlify.app