Partitioning failed: Failed to commit unwrap panic

[jtojnar]

I created an ext4 partition using GParted so I only chose to mount to / without formatting but partitioning failed because of this unwrap:

https://github.com/snowfallorg/icicle/blob/edaa74a9f8199984a86688a359c63bb33e906e36/icicle-helper/src/main.rs#L106

It appears to work when I let the installer reformat the partition.

Logs

``` === Icicle Log === 00:07:05 [INFO] Resource loaded: /nix/store/317s5l3hq1xwrpdc3rh2c7lsz0kgjnas-icicle-0.0.2/share/icicle/resources.gresource 00:07:09 [DEBUG] (1) icicle::utils::parse: Parsing config /etc/icicle/config.yml 00:07:13 [DEBUG] (1) icicle::ui::pages::timezone: Selected timezone: Some("America/New_York") 00:07:14 [DEBUG] (4) reqwest::connect: starting new connection: http://nmcheck.gnome.org/ 00:07:16 [INFO] Selected language: Some("en_US.UTF-8") 00:07:16 [DEBUG] (1) icicle::ui::pages::partitions: Got disks: [InputDisk { name: "/dev/sda", size: 21474836480, partitions: [] }, InputDisk { name: "/dev/sr0", size: 2679111680, partitions: [InputPartition { name: "/dev/sr0p2", _format: "unknown", size: 12582912 }] }] 00:07:16 [INFO] Partition: "/dev/sr0p2" length 12.0 MiB 00:07:26 [DEBUG] (1) icicle::ui::window: StackPage: Carousel 00:07:26 [DEBUG] (1) icicle::ui::window: Config: Some(InstallationConfig { config_id: "basic", config_name: "Basic Installation", config_logo: "emoji-symbols-symbolic", config_type: Snowfall, imperative_timezone: true, steps: [Welcome, Keyboard, Location, User { root: None, hostname: None }, Partitioning, Summary], commands: [] }) 00:07:27 [DEBUG] (1) icicle::ui::pages::user: Hostname changed to the same value, ignoring 00:07:29 [INFO] Selected language: None 00:07:42 [INFO] Selected language: Some("en_GB.UTF-8") 00:08:12 [DEBUG] (1) icicle::ui::pages::partitions: Got disks: [InputDisk { name: "/dev/sda", size: 21474836480, partitions: [] }, InputDisk { name: "/dev/sr0", size: 2679111680, partitions: [InputPartition { name: "/dev/sr0p2", _format: "unknown", size: 12582912 }] }] 00:08:12 [INFO] Partition: "/dev/sr0p2" length 12.0 MiB 00:09:05 [DEBUG] (1) icicle::ui::pages::partitions: Got disks: [InputDisk { name: "/dev/sda", size: 21474836480, partitions: [InputPartition { name: "/dev/sda1", _format: "ext4", size: 21472739328 }] }, InputDisk { name: "/dev/sr0", size: 2679111680, partitions: [InputPartition { name: "/dev/sr0p2", _format: "unknown", size: 12582912 }] }] 00:09:05 [INFO] Partition: "/dev/sda1" length 20.0 GiB 00:09:05 [INFO] Partition: "/dev/sr0p2" length 12.0 MiB 00:09:18 [DEBUG] (1) icicle::ui::pages::summary: SetConfig: Some("en_GB.UTF-8"), Some("cz+qwerty"), Some("Europe/Berlin"), Some(Custom({"/dev/sda1": CustomPartition { format: None, mountpoint: Some("/"), device: "/dev/sda" }})), Some(UserConfig { name: "f", username: "f", password: "*****", hostname: "snowflakeos", rootpassword: None, autologin: false }) 00:09:21 [DEBUG] (1) icicle::ui::window: StackPage: Install 00:09:21 [DEBUG] (1) icicle::ui::window: Installing! 00:09:21 [INFO] Step 0: Clear /tmp/icicle 00:09:21 [INFO] Step 1: Setup and mount partitions 00:09:21 [DEBUG] (3) icicle::utils::install: Executing partition with json: {"Custom":{"/dev/sda1":{"format":null,"mountpoint":"/","device":"/dev/sda"}}} 00:09:22 [DEBUG] (3) icicle::utils::install: PARTITION OUTPUT: Partitions: Partitioning disk /dev/sda 00:09:22 [DEBUG] (3) icicle::utils::install: PARTITION OUTPUT: Partitions: Committing changes 00:09:22 [ERROR] Partitioning failed: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failed to commit', icicle-helper/src/main.rs:106:25 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 00:09:22 [ERROR] Failed to partition: Partitioning failed: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failed to commit', icicle-helper/src/main.rs:106:25 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 00:09:22 [DEBUG] (1) icicle::ui::window: Error! === End of Icicle Log === === nixos-install Log === No log found! === End of nixos-install Log === ```