search

snowfallorg / nix-software-center

A simple gtk4/libadwaita software center to easily install and manage nix packages
GNU General Public License v3.0
572 stars 16 forks source link

Some icons/screenshots of famous softwares are not displayed #57

Open tobiasBora opened 8 months ago

tobiasBora commented 8 months ago

Thanks again for this nice software. Surprisingly, some icons/screenshots of famous softwares are not displayed, in my case firefox and chromium have no icons:

image

Also I'm curious, how are icons/screenshots even obtained? Might interest also https://github.com/snowfallorg/nix-software-center/issues/53

Edit: so it seems icons are obtained via this format https://www.freedesktop.org/wiki/Distributions/AppStream/, I guess downloaded from https://www.freedesktop.org/software/appstream/releases/

KiaraGrouwstra commented 7 months ago

i see icons included as build input here (gnome.adwaita-icon-theme)

tobiasBora commented 7 months ago

I don't think this is related, adwaita-icon-theme seems to only contains icons like "new file", "new folder" etc, not application-related icons.

KiaraGrouwstra commented 7 months ago

might it be this just uses system icons?

tobiasBora commented 7 months ago

Well each software installs the icons when they get install. I do believe it is obtained using the above AppStream stuff

KiaraGrouwstra commented 7 months ago

hm, as an app store it shows applications that have not yet been installed too right?

tobiasBora commented 7 months ago

Sure, that's precisely why we can't rely on system-installed icons

KiaraGrouwstra commented 7 months ago

hm, i was under the impression installed icon packs may well include icons for a bunch of applications not necessarily restrained to applications that have been installed. personally, as a user i tried installing such a pack i found pretty, meaning i would actually prefer for it to be used.

tobiasBora commented 7 months ago

Well, I guess custom icon themes are ignored by this program, but to be honest I have no idea. In any case, even if the icon does not follow the theme, it will only be show in nix-software-center, but after installation, you will of course see the custom theme in your desktop list of applications etc. If you still want to use your theme icon pack for nix-software-center, I guess you want to fill a separate bug.