search

snowflakedb / SnowAlert

Security Analytics Using The Snowflake Data Warehouse
Apache License 2.0
184 stars 57 forks source link

Adding CodeMirror 6 #523

Closed sfc-gh-nlele closed 2 years ago

sfc-gh-nlele commented 3 years ago

After making changes, the only part that was not working as supposed to was 'Format'. It was only updating the rule body with the expected formatting, but that wasn't getting reflected on the editor. To get around this, I tried to use a workaround, but now: when the formatter is used (with 'Format'), and then if I try to save it, a compilation error occurs. Apply/saving seems to be working fine if its done normally.

sfc-gh-afedorov commented 3 years ago

I'm not sure if I follow how the format button is working given that it's just toggling a bool -- maybe add a comment to explain? we'll likely refactor the Format functionality (or the server to be more accepting of alternative formatting), so no worries on keeping it working perfectly

sfc-gh-nlele commented 3 years ago

Added a comment for that, ah okay!

sfc-gh-afedorov commented 3 years ago

looks like the WhiteSource security checks are not working -- we'll need those before we can merge this change