search

snowflakedb / SnowAlert

Security Analytics Using The Snowflake Data Warehouse
Apache License 2.0
184 stars 57 forks source link

[DC] Add EC2 Describe Snapshots to AWSIC #527

Closed sfc-gh-gkadam closed 3 years ago

sfc-gh-gkadam commented 3 years ago

[Blusec-385 Detect public EBS snapshots] (https://snowflakecomputing.atlassian.net/browse/BLUSEC-385) Added table name as - 'ebs_describe_snapshot' in supplementary tables Added API method spec name - 'ebs.describe_snapshot' added 'ebs.describe_snapshot' under collect apis

sfc-gh-dwyleczukstern commented 3 years ago

@sfc-gh-afedorov It looks like the PR is failing because whitesource is complaining that SnowAlert is using out of date libraries. Is that assessment correct? Should we submit a separate PR to update those libraries?

sfc-gh-afedorov commented 3 years ago

not immediately sure why this is failing but v1.10.0 should be up-to-date with Whitesource requirements -- https://github.com/snowflakedb/SnowAlert/runs/2345087173

almost done fixing / testing this, would you like the changes merged in, or as comments to understand them better going forward?

sfc-gh-gkadam commented 3 years ago

I have made the request changes still am seeing the "Changes Requested" tab. @sfc-gh-afedorov