search

snowflakedb / gosnowflake

Go Snowflake Driver
Apache License 2.0
292 stars 122 forks source link

Perf for structured type - snowflakeType calculated only once #1097

Closed sfc-gh-pfus closed 4 months ago

sfc-gh-pfus commented 4 months ago

Description

SNOW-1321823 Calculate snowflakeType only once. During structured types implementation a perf bug was introduced - snowflakeType for column was calculated every time for each row. Now it is calculated only once per batch.

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.05%. Comparing base (5e6ed86) to head (44917c2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1097 +/- ## ======================================= Coverage 77.05% 77.05% ======================================= Files 52 52 Lines 10949 10949 ======================================= Hits 8437 8437 Misses 2512 2512 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.